This post may be at a little bit of a tangent to Edy's question, but I think it's part of the answer: the advice that one should take notice of - in relation to our writing as in any other area of life - is informed advice. And our own understanding of what makes a good and bad piece of writing needs to be informed too, so we can read our work with a critical eye.
So here are some thoughts on how to give and take criticism of a piece of writing. They are particularly aimed at group situations such as a writers' circle. One needs, of course, to be particularly sensitive here, as any criticism of one person's writing is made publicly and in the presence of others. But the principles I discuss here hold good whether the criticism is written, spoken, on a one to one basis, or even just between you and your internal editor.
CONSTRUCTIVE CRITICISM
For criticism of a piece of writing to be helpful to the writer, the emphasis should be on the word 'constructive'.
Basic guidelines:Criticise the piece of work, not the author. Be impersonal and objective and always justify your statements.
Be honest but kind.
Don’t make empty statements that you can't justify or back up with evidence. Say when you think there are weaknesses or faults but always give reasons why you think this.
Give suggestions for how you think work could be improved when pointing out weaknesses.
If there are particularly good things in the work, say so. Praise is as important as criticism.
No one person's opinion is more valid than another's. Don't battle to impose your view on the rest of the group.
Centring discussion around the basic components of the piece encourages objectivity.
Questions to ask about fiction or drama: PLOT - Is it logical, consistent and free from unnecessary diversions? Does it have a strong opening, a good middle and a satisfying conclusion? If flashbacks are used, are they necessary and/or handled effectively?
CHARACTERS - Are there too many? Are they well-rounded, believable and individualistic? Are they consistent, or if they act 'out of character' is there a reason for it and is this justified?
DIALOGUE - Is there too much or too little? Does it suit the characters? Is it natural? Is it used effectively and appropriately?
STRUCTURE - Does it move forward in a logical and progressive way? Is there a variety of tone - i.e. are there high and low points and are these effective?
VIEWPOINT - Has the story been told from the right (or the best) viewpoint?
TONE - Is the tone right for the piece?
Articles or non-fiction:
SUBJECT MATTER - Is the information clearly conveyed? Is it too long-winded, or underwritten?
RESEARCH - Is it accurate and up-to-date? Would further research or information improve it?
STRUCTURE - Does it proceed in a logical and progressive way and does it achieve what it sets out to achieve?
Poetry:
RHYTHM & RHYME - If it's written to a set verse form, are the rhythm and rhyme correct for the form? If not, are the rhythm and rhyme internally consistent? If they aren't, is it for a particular reason and does that work well or not?
WORDS - Are the imagery and use of words good, bad or indifferent? Why do you think this?
IDEAS - Are the ideas expressed a) valid and b) worth expressing?
TONE - Is it right for the sentiments expressed?
General:
Do you like or dislike the piece of work? Why?
Could it be improved? How?
What are the good and bad points of the piece? Justify your personal opinion.
If the piece has been written for a particular market, is it the right one? How should it be re-written to suit the market? Have you any other suggestions for markets?
How to accept criticism:
When it is your piece of work that is being criticised, listen to the comments with an open mind. Try not to take exception to what's being said - remember it is the piece of work, not yourself, that is being criticised. Make a note - mental or written - of all comments that are made. It is just as important to make note of positive comments as negative - if you do something well, you should try to repeat it in future work as well as avoiding things you have done badly. If there is a general consensus about certain points, think very seriously about making changes in that area. If one person has a different view from the rest, it can more safely be disregarded. Don't waste time arguing with those who make comments - they are entitled to give their opinion even if you don't agree with it. Listen carefully to opinions which oppose your own because you might need to strengthen your argument to forestall some likely counter-arguments which hadn't struck you before.
Later, re-read your piece in the light of the comments made. Decide which ones you agree with and which you don't. If you're not sure, try a re-write of the relevant section and compare it with the original version. Which do you prefer/ think works best? Do extra research if necessary and re-write your piece to include it. Where people have misunderstood what you are saying, don't immediately put it down to their stupidity - the chances are you haven't expressed/explained it clearly enough. Re-write to clarify your meaning. Strengthen your arguments where necessary to forestall possible counter-arguments. Just as important as making changes, is having the confidence, and belief in your own work, to decide not to make changes in certain places. In the end, it's your work and you are entitled to ignore any comments which you don't agree with. But remember, writing is communication and if you aren’t communicating with your readers in the way you had intended, you have failed.
Finally:Learning to constructively criticise the work of others is an important step towards being able to criticise and edit your own work effectively. Get into the habit of practising on pieces you read in magazines, newspapers, books.